Skip to content

Release 5.4.0 - #546

Merged
kornelski merged 1 commit into
masterfrom
release/5.4.0
Oct 30, 2026
Merged

kornelski merged 1 commit into
masterfrom
release/5.4.0

Conversation

@kornelski

Copy link
Copy Markdown
Contributor

No description provided.

@kornelski
kornelski requested a review from nox October 30, 2026 10:59

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 Approved with comments — The version bump is consistent across the workspace and the release notes are updated. The only comment is a non-blocking suggestion about out-of-order dates in the release notes.

Findings: 1 suggestion

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


🚀 Release: 💬 1 suggestion

Version bump is consistent; one minor release-notes ordering nit

Recommendation: 💬 Optional Nits

  • [SUGGESTION] RELEASE_NOTES 5.4.0 section: two entries dated 2026-03-27 sit between October entries, out of the newest-first order the other entries follow. They are probably author dates of older commits; consider reordering them or using the merge dates. (RELEASE_NOTES:6)
View full review

Risk: Low

The workspace version and the boring-sys/boring/tokio-boring dependency versions in Cargo.toml are all bumped from 5.3.0 to 5.4.0. RELEASE_NOTES gains a 5.4.0 section. Two entries are dated 2026-03-27 and sit between October entries, out of the newest-first order the other entries follow. The release scope could not be compared against the previous tag because tag history is not available here.


Reviewed commit: a9c6c387

@kornelski
kornelski merged commit 309bf35 into master Oct 30, 2026
29 checks passed
@kornelski
kornelski deleted the release/5.4.0 branch October 30, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants