feat(smurf-tf-drift): fix false drift detection and add env-specific alerts - #452
Open
sunnymor-cd wants to merge 2 commits into
Open
sunnymor-cd wants to merge 2 commits into
sunnymor-cd wants to merge 2 commits into
Conversation
sunnymor-cd
requested review from
a team,
anmolnagpal and
clouddrove-ci
as code owners
September 15, 2026 12:25
anmolnagpal
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the shared
smurf-tf-driftworkflow to correctly detect actionable Terraform drift and avoid false positives when Terraform reports no infrastructure changes. Adds environment-aware issue and Slack notifications, configurable Slack alert titles, drift-related outputs, and improved drift handling for reusable single- and multi-environment workflows.Type of Change
Workflow Category
tf-*)cf-*)docker-*)helm-*)pr-*)security-*)release-*)notify-*)aws-*)gcp-*)yl-*)Checklist
Testing
Tested the shared workflow using staging, prod-us, and prod-eu Terraform environments.
No changesdo not report drift.yamllintand fixed formatting and lint issues.Screenshots/Documentation
Related Issues
Closes #
Additional Notes
The workflow remains reusable for both single-environment and multi-environment Terraform setups. Environment-specific values are provided by the caller, allowing the shared workflow to handle Terraform drift detection, GitHub issues, and Slack notifications consistently.