Repository navigation
Highlights: ask for a number, and the best that many are chosen from all the picks - #67
Merged
Merged
Conversation
…all the picks
A count written in the brief never held: each reading sees a dozen clips of
one folder, so it applied to each dozen, and two cameras on one moment were
never compared. A project now says how many highlights it wants. Every clip is
still read as before; once none is left, one more model call reads all the
picks and puts them in order for the brief: the best set of that many first
(the mix the brief asks for, one clip may give most of it, never the same
moment twice), then stand-ins, then the rest by score.
- PUT /api/projects/{id}/highlights/wanted, and `wanted` on asking; pick=best
in the list and the export. Kept picks count first.
- Dropping one of the best brings in the next with no model call. A new number
orders them again at once; picks from clips read later do too, at most every
15 minutes while footage is still coming in.
- The review page asks how many, opens on the best, and exports them; the AI
editor prefers them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A count written in the brief ("max 25 clips") never held. Each reading sees a dozen clips of one folder, so the count applied to each dozen, and two cameras on one moment were never compared.
What
wanted, 1 to 200, or none (every pick worth a look, as before).pick=bestin the list and the export. Kept picks count first; when more are kept than wanted, the best of the kept.agent.mdand the README describe it.New state:
edit_projects.highlights_wantedand the ordering's status, error and claim time, plusfootage_highlights.rank.Checks
pnpm test: 210 pass.pnpm test:e2e: ALL OK. New scenarios 11h to 11h4:pnpm typecheckandpnpm buildpass.