Skip to content

test(evm-node): cover rpc_get_version field population - #472

Closed
kutluhaneth46 wants to merge 1 commit into
circlefin:mainfrom
kutluhaneth46:cursor/rpc-get-version-tests-88c1
Closed

kutluhaneth46 wants to merge 1 commit into
circlefin:mainfrom
kutluhaneth46:cursor/rpc-get-version-tests-88c1

Conversation

@kutluhaneth46

Copy link
Copy Markdown
Contributor

Closes: #447

Adds unit tests for rpc_get_version():

  • returns Ok
  • git_version / git_commit / git_short_hash / cargo_version non-empty
  • git_short_hash is a prefix of git_commit

Requested assignment on the issue. Happy to adjust if maintainers prefer a different coverage shape.

Closes: circlefin#447

Assert non-empty version fields and short-hash/commit consistency.
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Unsigned Commits Detected

The following commits are missing a verified signature:

  • ffd586e by kutluhaneth46

How to fix: Sign your commits.

@github-actions

Copy link
Copy Markdown
Contributor

Hi @kutluhaneth46,

Thank you for your interest in contributing to Arc Node.

This PR has been automatically closed because you are not assigned to issue #447. We require contributors to be explicitly assigned to an issue before submitting a PR.

To contribute properly:

  1. Comment on issue test(evm-node): add unit tests for rpc_get_version #447 requesting assignment
  2. Wait for maintainer approval
  3. Only submit a PR after you have been assigned

Please see our CONTRIBUTING.md for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(evm-node): add unit tests for rpc_get_version

1 participant