Repository navigation
feat: support externally controlled highlights - #4405
Merged
Merged
Conversation
hamed-musallam
force-pushed
the
external-highlighting
branch
from
October 5, 2026 15:19
cafe5ee to
ed5ffa3
Compare
Deploying nmrium with
|
| Latest commit: |
7aa2667
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://da7cea26.nmrium.pages.dev |
| Branch Preview URL: | https://external-highlighting.nmrium.pages.dev |
hamed-musallam
marked this pull request as draft
October 5, 2026 15:24
hamed-musallam
marked this pull request as ready for review
October 6, 2026 07:31
Member
Author
|
Can you review the functionality? |
vcnainala
added a commit
to NFDI4Chem/nmrium-react-wrapper
that referenced
this pull request
Oct 6, 2026
Switch from the controlled highlight / onHighlightChange API (#4402) to the additive highlightedIds prop from cheminfo/nmrium#4405. Host highlights no longer touch NMRium's internal highlight state, so the sourceData workaround and the permanent option are gone. Drop the embedding settings from the QM demo fixture: they hide NMRium's panels, which the demo and e2e tests rely on.
vcnainala
added a commit
to NFDI4Chem/nmrium-react-wrapper
that referenced
this pull request
Oct 9, 2026
Switch from the controlled highlight / onHighlightChange API (#4402) to the additive highlightedIds prop from cheminfo/nmrium#4405. Host highlights no longer touch NMRium's internal highlight state, so the sourceData workaround and the permanent option are gone. Drop the embedding settings from the QM demo fixture: they hide NMRium's panels, which the demo and e2e tests rely on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.