Repository navigation
feat: reorder spectra by drag and drop and persist the order in the original state - #4399
Merged
Merged
Conversation
Deploying nmrium with
|
| Latest commit: |
c06e3c0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e247bea1.nmrium.pages.dev |
| Branch Preview URL: | https://react-table-drag-drop-reorde.nmrium.pages.dev |
Member
|
Looks good ! Could we just make this first column much smaller so that it takes not a lot of room even maybe without separator just after ? Also could we avoid that when we leave the droppable zones there is a '+' appearing. Seems weird. 
|
Member
Author
the '+' icon, it's Chrome’s native drag-and-drop cursor, and now I prevent showing the icon over the table . |
Member
Author
|
Be aware that Safari and Chrome generate the native drag preview differently. |
lpatiny
approved these changes
Oct 5, 2026
fix: prevent copy cursor during table row reordering Allow same table drop targets with a move effect and ignore self drops. refactor: reduce table row drag handle width refactor: prevent copy cursor when dragging table rows
hamed-musallam
force-pushed
the
react-table-drag-drop-reorder
branch
from
October 5, 2026 09:03
dbe2efa to
c06e3c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.