Skip to content

fix: update correlation and load it correctly - #4390

Merged
hamed-musallam merged 5 commits into
mainfrom
fix-summary-table
Sep 30, 2026
Merged

hamed-musallam merged 5 commits into
mainfrom
fix-summary-table

Conversation

@hamed-musallam

Copy link
Copy Markdown
Member

No description provided.

@hamed-musallam

Copy link
Copy Markdown
Member Author

@michaelwenk

Could you check the Summary Panel's functionality

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1029b0b
Status: ✅  Deploy successful!
Preview URL: https://9a41029d.nmrium.pages.dev
Branch Preview URL: https://fix-summary-table.nmrium.pages.dev

View logs

Avoid remapping correlation values during load and assume hybridization values are already numeric
Remove the unnecessary correlation update and apply changes to
the current correlation data.
@michaelwenk

Copy link
Copy Markdown
Member

@hamed-musallam It looks good to me. Thank you!

@hamed-musallam hamed-musallam changed the title fix: crash when loading or changing correlation data fix: update correlation and load it correctly Sep 30, 2026
@hamed-musallam
hamed-musallam enabled auto-merge (squash) September 30, 2026 08:25
@hamed-musallam
hamed-musallam merged commit 69adcff into main Sep 30, 2026
12 checks passed
@hamed-musallam
hamed-musallam deleted the fix-summary-table branch September 30, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No table/data update when editing in summary panel Summary panel does not show correlation data after data import

2 participants