Repository navigation
feat: generate jsonrpc headers at build time - #8350
Merged
Merged
Conversation
d2weber
force-pushed
the
d2weber/buildtime_jsonrpc
branch
from
September 3, 2026 09:38
1d69a54 to
28091ad
Compare
d2weber
force-pushed
the
d2weber/buildtime_jsonrpc
branch
from
September 3, 2026 09:41
28091ad to
b1e55eb
Compare
d2weber
marked this pull request as ready for review
September 3, 2026 11:35
Member
|
Once yerpc is updated to new release and this PR is merged, we can finally remove unused web socket dependencies as well #7723 |
link2xt
previously approved these changes
Sep 8, 2026
link2xt
reviewed
Sep 8, 2026
Collaborator
There was a problem hiding this comment.
This needs to be fixed, otherwise releasing will fail
link2xt
dismissed
their stale review
September 8, 2026 19:10
Working directory in CI still needs update
link2xt
approved these changes
Sep 8, 2026
hpk42
added a commit
that referenced
this pull request
Oct 6, 2026
Since #8350 (2026-09-09) deltachat-jsonrpc-bindings build-depends on deltachat-jsonrpc, so clippy, nextest and the doctests, which select the whole workspace, compiled core and its whole dependency tree a second time for the host. The lint job also checked every dependency twice, once per panic strategy, and repeated clippy's checks in a separate all-features `cargo check`. With a warm cache on 4 CPUs on my machine, the lint job drops from 150 to 60 seconds and the tests build from 100 to 75 seconds. Peak memory falls for lint from 5.1 to 3.5 GiB and for tests 7.5 to 5.4 GiB.
hpk42
added a commit
that referenced
this pull request
Oct 6, 2026
Since #8350 (2026-09-09) deltachat-jsonrpc-bindings build-depends on deltachat-jsonrpc, so clippy, nextest and the doctests, which select the whole workspace, compiled core and its whole dependency tree a second time for the host. The lint job also checked every dependency twice, once per panic strategy, and repeated clippy's checks in a separate all-features `cargo check`. With a warm cache on 4 CPUs on my machine, the lint job drops from 150 to 60 seconds and the tests build from 100 to 75 seconds. Peak memory falls for lint from 5.1 to 3.5 GiB and for tests 7.5 to 5.4 GiB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion in chatmail/yerpc#77. The necessary yerpc changes for this PR are in chatmail/yerpc#78
This is also a preparation for #8330