Conversation
Assisted-by: OpenAI Codex
LeeLenaleee
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11905. Revisits the zero-tick formatting problem from the author-closed #12260.
Numeric ticks return the literal
0before applyingticks.format, so currency and percent axes lose their unit at zero. Format zero with the configured locale/options, using zero fractional digits by default and allowing explicit precision to override that default. Keep zero outside automatic scientific-notation selection.Added chart-level regressions for percent, currency, and explicit two-decimal currency formatting, plus coverage for the existing plain-zero behavior with empty, single-tick, fractional, and large-range tick lists.
Validation on macOS arm64, Chrome Headless 151:
0instead of0%,$0, and$0.00); all 6core.tickstests pass with the fix.pnpm run lintpasses, including the build and type checks (existing warnings in unchanged files).AI assistance: OpenAI Codex assisted with implementation, tests, and verification.