Repository navigation
test(e2e): wait for the example to hydrate after page.goto - #3544
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
page.gotoresolves on load, before SSR examples (Vue, Svelte, Solid) hydrate, so early clicks and key presses were lost and tests failed locally.html[data-ready]once the page has hydrated:useEffectin Next's_app, Nuxt'spage:finishhook, SvelteKit'safterNavigate, a component inside Solid's routeSuspense, and preact-iso'sonLoadEnd/onRouteChange.e2e/_test.tsextends Playwright'stestsopage.gotowaits for the marker; specs importtest/expectfrom it.Local
menu.e2e.ts(no retries): Vue 1 → 8 passed, Solid 4 → 7, Svelte 8. The rest fail on routes or example content that don't exist in those frameworks (menu/overflow,menu/links). React: menu, tabs-links, tour, combobox 87 passed.