Repository navigation
fix(dom-query): close presence-mounted overlays on Escape before the next frame - #3543
Merged
Merged
Conversation
…ks for presence-mounted content
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: 40c0351 The changes in this PR will be included in the next version bump. This PR includes changesets to release 85 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3483
Problem
whenNodechecked for the node in a microtask, then fell back to the next frame. Content mounted through presence (lazyMount/unmountOnExit) commits after that microtask, so the dismissable layer, and its Escape listener, only registered a frame later. An Escape in that window was lost and the menu stayed open.Fix
While waiting for the frame,
whenNodealso listens for DOM insertions on the caller's root node through a sharedMutationObserver(one native observer per target and config) and resolves on whichever comes first.whenNode,trackDismissableElementandtrackDismissableBranchtake agetRootNodeoption; without it, only the frame fallback runs.scope.getRootNode, so shadow roots and iframes are observed where the content is queried.Tests
menu/presenceexample in React, Vue, Solid and Svelte.e2e/menu-presence.e2e.ts: with frames paused, open then press Escape. React fails on main (aria-expandedstaystrue), passes with the fix.