Repository navigation
Conversation
Add the Python version to the virtualenv cache key, run create_python_cache as a 3.12/3.14 matrix, self-test on both versions and bump the fixture's uWSGI to the first release that builds on 3.14. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Member
Author
|
CI green on 3.12 and 3.14 (python job), node and CodeQL. The venv cache keys now contain |
pdelsante
marked this pull request as ready for review
October 5, 2026 10:06
Default to ["3.12"], the behaviour before this branch. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
|
Questa PR non mi convince più di tanto, per il momento la chiudo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Make
create_python_cache.yamland the shared.ruff.tomlsupport Python 3.14 alongside 3.12.Why
Projects are moving to 3.14. Today the venv cache key ignores the Python version, so a multi-version matrix would collide on save, or restore a venv built for the wrong interpreter.
How
save_virtualenv/restore_virtualenv: add aget_python_versionstep; key is now<ref>-venv-py<X.Y>-<hash>. Inputs are unchanged; existing venv caches miss once.create_python_cache.yaml: matrix fromvars.PYTHON_VERSIONS(JSON array, default["3.12"]= previous behaviour) withfail-fast: false, so a version that fails to build doesn't cancel the others' caches..ruff.toml: keeptarget-version = "py312"(it is the minimum and already covers 3.14 code) with a one-line comment.pull_request_automation.yml:python_versionsreads the samevars.PYTHON_VERSIONS(default["3.12"]), so tests and caches use the same versions.uWSGI2.0.23 → 2.0.30, the first release that builds on 3.14 (2.0.29 fails onc_recursion_remaining).workflows/README.mdand both virtualenv action READMEs..claude/plans/ci-python-3.14/plan.md.Out of scope
PYTHON_VERSIONSon this repo: without it the self-test runs only 3.12..github/drift in_release_and_tag.yml,release.ymlandrequirements-linters.txtthatpost-mergewould sync.create_python_cache.yamlitself only runs on push to develop/main, so this PR's CI exercises it only indirectly, through the shared actions.🤖 Generated with Claude Code