Repository navigation
docs(ledger): drop two pinned Celo Ledger app versions - #2337
Merged
Merged
Conversation
Both were stale by several major versions. The current Celo Ledger app is 1.8.2 (LedgerHQ/app-celo-spender tag stax_1.10.1_1.8.2_sdk_v26.6.1). - home/manage/self-custody.mdx said the latest app was 1.1.8 and told the reader to upgrade. The Note is removed rather than renumbered: the setup page it links already documents the Upgrade flow, so this was a duplicate of a fact that belongs on one page. - tooling/wallets/ledger/setup.mdx said Install would put version 1.0.3 on the device. Ledger Live installs whatever is current, so the sentence now says that instead of naming a version that nothing regenerates. Left alone: the 1.3.2 in ledger/eip712-workaround.mdx sits under "Tested Configurations", where a fixed version is the point. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
GigaHierz
requested review from
palango and
seolaoh
and removed request for
a team
September 25, 2026 10:12
palango
approved these changes
Sep 25, 2026
palango
left a comment
Contributor
There was a problem hiding this comment.
Removing the numbers instead of renumbering them is the right call, and the setup page already covers the Upgrade path. One small nit inline.
Heads-up: this conflicts with #2338 in home/manage/self-custody.mdx, because #2338 rewrites the link inside the Note you delete here. Whichever merges second needs to keep the deletion.
| Search for “Celo” in the app store. | ||
|
|
||
| Click **Install** for the Celo app, this will install the Celo App Version 1.0.3 on your device. | ||
| Click **Install** for the Celo app. Ledger Live installs the current version. |
Contributor
There was a problem hiding this comment.
Nit: two lines up the same step calls it "the Ledger Wallet App". Using one name for the app within this step would read better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hole, and the fix
Two pages named a specific Celo Ledger app version. Both were wrong, and had been for a long time.
The current app version is 1.8.2 —
LedgerHQ/app-celo-spendertags arestax_<ledger-live>_<app>_sdk_<sdk>, and the newest three are:home/manage/self-custody.mdxsaid:tooling/wallets/ledger/setup.mdxsaid:This is worse than cosmetic on the self-custody page: it is a
ReleaseGoldguide, so a reader on 1.5 is told they are ahead of the latest release and can skip the upgrade.What changed, and why not just renumber
Renumbering buys about a month. Neither number is generated from anything, so both drift silently and nothing turns red.
<Note>is removed, not updated. The setup page it already links documents the Upgrade path ("If you've previously installed the Celo app on your device, you'll see an Upgrade option instead of Install"), so this was a second copy of a fact that belongs on one page — AGENTS.md §7.What this does NOT do
ledger/eip712-workaround.mdx:106("Celo App: version 1.3.2") alone. It sits under## Tested Configurationsalongside pinned Celo Terminal and firmware versions. A fixed version is the entire point of that section; it is a record of what was tested, not a claim about what is current./wallet/…links on these pages.self-custody.mdxstill links/wallet/ledger/setupfour times, which only resolves through the/wallet/:slug*wildcard redirect rather than pointing at/tooling/wallets/ledger/setupdirectly. That is not specific to this page — there are 25 such links across 12 files, left over from the wallets move. It is a separate, mechanical concern and I am raising it separately rather than widening this diff.Verification
Grep for other pinned Celo Ledger app versions across the repo returns only the
eip712-workaroundline discussed above.Issues
No ticket. Found while checking a version claim on a different PR (#2304), which removed a "Celo app 1.8 or later" line for the same reason: no source behind the number.
🤖 Generated with Claude Code