Copy arm64 files for AnyCpu builds - #5288
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Build CefSharp 150.0.110-CI5605 completed (commit 8966f2e74e by @drymay82) |
Addition to PR: #5267
Fixes: #4155
Summary:
Changes:
CefSharpTargetDirAnyCpuArm64, resolving toarm64\.CefSharpBuildAction=NoneAnyCPU path, adds ARM64 copies for:@(CefRedistArm64)— CEF redistribution/native resources@(CefSharpCommonBinariesArm64)—CefSharp.Core.Runtime.dll, browser subprocess files, etc.@(CefSharpCommonManagedDll)—CefSharp.dll, required by the architecture-specific browser subprocess folderCefSharpBuildAction=ContentAnyCPU path.How Has This Been Tested?
netarm64branch including my changes<CefSharpAnyCpuSupport>true</CefSharpAnyCpuSupport> <CefSharpPlatformTargetOverride>AnyCPU</CefSharpPlatformTargetOverride> <PreferNativeArm64>true</PreferNativeArm64Process architecture: Arm64 Expected runtime: ...\arm64\CefSharp.Core.Runtime.dll Expected CEF runtime: ...\arm64\libcef.dllI also validated these changes the same way in our product’s cefsharp-browser application: it builds as AnyCPU with the ARM64 CefSharp runtime included and prefers native ARM64 execution on supported Windows devices.
Types of changes
Checklist: