Rename PTF_formula to ptf_formula with a deprecation alias - #1316
Abhayindia wants to merge 2 commits into
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): 50.0% fully typed (1 / 2)
Patch symbol details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1316 +/- ##
==========================================
+ Coverage 91.79% 92.73% +0.94%
==========================================
Files 96 98 +2
Lines 5494 6206 +712
Branches 707 839 +132
==========================================
+ Hits 5043 5755 +712
- Misses 327 329 +2
+ Partials 124 122 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Note to reviewers: I'd like for #1318 to be resolved before we review/close this. |
7ca7723 to
534c378
Compare
|
FYI the PR with the new deprecation tools is this one #1323. It's still under review but it should give you a general idea on the new tools that will be available to you to complete this PR. |
|
thanks, that's helpful - |
534c378 to
c19902a
Compare
|
@Abhayindia github overreacting... @genedan i don't think you meant to close it. please confirm |
|
Must have been an accident. @Abhayindia, the new deprecation tools are ready. FYI, we changed which function will be the wrapper. The |
|
It's because I said "needed to close #XXXX" in another PR. Guess I gotta change my language..."blocker for #XXXX"? |
Summary of Changes
Renames
PTF_formulatoptf_formula. The old name stays as a thin wrapper that emits aDeprecationWarningand forwards to the new one, so nothing breaks for 0.11.0. The internal caller inbarnzehn.pyis switched to the new name.Related GitHub Issue(s)
Closes #1291
Additional Context for Reviewers
Added
test_ptf_formula_deprecated_alias— checks the alias warns and returns the same formula string.ruff check --config lint.per-file-ignores={}andruff format --checkpass on the three changed files;pytest chainladder/development/tests/test_barnzehn.pypasses. Couldn't run the doctest builder locally (nojb), but no docs referencePTF_formula.Checklist