Repository navigation
Fix debugger streaming worker - #1185
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
e7c450c to
c193afa
Compare
|
@codex review |
c193afa to
42c8247
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c193afab86
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Status.completed, | ||
| }: | ||
| return self.execution.active_bot |
There was a problem hiding this comment.
When a native protective order fills while a position increase is still pending, FuturesPosition.record_protective_fill() can mark the bot completed while deal.position_size_order remains set. This new early return bypasses the completed-bot branch in Lifecycle.exit(), which calls close_all() to cancel that increase and flatten any residual exposure. The outstanding order can therefore reopen an unprotected position after the bot has been retired. Preserve that cleanup before returning completed bots; the existing test_native_trailing_fill_cancels_a_pending_increase_before_retiring_bot tests exit() directly and does not cover this new process_tick() bypass.
Useful? React with 👍 / 👎.
No description provided.