Repository navigation
Show each database adapter and the cancel call - #76
Conversation
The agent guide showed only the SQLite import and never named
unschedule(). In the Track B evaluation, Claude Code sketches imported
postgres from solid-objects/database/postgres and called
this.cancelReminder(). Neither name exists.
The guide now has a table with the import path, the call, and the
driver of each SQL database adapter. The rules show
this.unschedule("expire", { key: buyer }), and the mistakes table
lists both invented names with the correct form. A new test fails when
the guide does not name the import path of each server database adapter
that package.json exports.
|
Docs7 for cardmagic/solid-objects-js
Commit |
 [Low impact] The PR appears safe to merge; both previous findings are fixed and no new actionable issues were found. SummaryThe guide now names each SQL adapter's import, call, and driver, and shows how to cancel reminders with
No new actionable issues were found. Reviews (2) · Last reviewed commit: "test: require each server database adapt..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The test listed today's three adapters, so a new server adapter would pass without a mention in the guide. It now selects each database export that is not a browser WebAssembly adapter, and the export type is concrete.
|
@greptileai Please review the current head 66cf87d. Both findings are corrected: the export type is concrete, and the test selects each database export that does not end with -wasm, so a new server adapter must appear in the guide. The redis job on the previous head failed on a refused image pull (Docker pull failed), not on a test. |
1 participant
Summary
The agent guide showed only the SQLite import and never named
unschedule(). In the Track B v8 evaluation, three Claude Code sketches used names that do not exist:postgresfromsolid-objects/database/postgres(two answers) andthis.cancelReminder()(one answer).Changes
docs/agents.md, step 4: a table with the import path, the call, and the driver for SQLite, PostgreSQL, and MySQL.docs/agents.md, step 6: the rules showthis.unschedule("expire", { key: buyer }), and the mistakes table lists both invented names with the correct form.test/agent-guide.test.ts: fails when the guide does not name the import path of each server database adapter thatpackage.jsonexports, or does not show the cancel call.CHANGELOG.md: an Unreleased entry.The Ruby pull request for the reminder guide is cardmagic/solid-objects-ruby (docs/reminder-cancellation).
Compatibility
Documentation and a test only. No code change.
Validation
pnpm run check,pnpm run format:check: pass.pnpm test: 77 files, 678 tests pass, 32 skipped.