Skip to content

Fix mirrored parts of modular ships - #93

Open
ccp-intern wants to merge 2 commits into
mainfrom
fix-mirrored-parts
Open

ccp-intern wants to merge 2 commits into
mainfrom
fix-mirrored-parts

Conversation

@ccp-intern

Copy link
Copy Markdown
Member

https://fenriscreations.atlassian.net/browse/PLAT-12004

Fixes mirrored parts on modular ships:

  • Decomposes matrix based on determinant, with (hopefully) safe mirror axis chosen by callers
  • Reverse winding helper in TriGeometryRes to dry code
  • Instanced meshes have lod indices with reverse winding and create separate batches
  • Reverse quad index buffer in Tr2Renderer, used by haze and boosters
  • Light radius and bounding sphere calculation with absolute values
  • BuildChild passes scale/rotation/translation so that roundtrip through Decompose doesn't kill negative scale

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-format v21.1.8

Click here for the full clang-format patch
diff --git a/trinity/Eve/EveInstancedMeshManager.cpp b/trinity/Eve/EveInstancedMeshManager.cpp
index 89d2894..c106aa1 100644
--- a/trinity/Eve/EveInstancedMeshManager.cpp
+++ b/trinity/Eve/EveInstancedMeshManager.cpp
@@ -853 +853 @@ void EveInstancedMeshManager::GetPickingBatches( EvePendingPickingReadback& read
-				
+

Have any feedback or feature suggestions? Share it here.

Comment thread trinity/Eve/EveInstancedMeshManager.cpp Outdated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
github-actions Bot dismissed their stale review September 16, 2026 16:53

outdated suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants