Skip to content

Fix a typo - #43

Open
katoue wants to merge 1 commit into
carbonengine:mainfrom
katoue:fix/pairing-heap-unlink-typo
Open

katoue wants to merge 1 commit into
carbonengine:mainfrom
katoue:fix/pairing-heap-unlink-typo

Conversation

@katoue

@katoue katoue commented Sep 16, 2026

Copy link
Copy Markdown

Summary

  • PairingHeap<T>::remove(nodeptr_t) called node->Unlink; (missing parentheses), which just formed an unused pointer-to-member-function expression instead of actually calling Unlink(). The node was never detached from its parent's child/sibling chain before being deleted, leaving a dangling pointer in the tree.
  • Changed to node->Unlink(); to match the correct call already used elsewhere (e.g. remove_min()'s use of DetachChildren).

Test plan

  • CI build/tests pass

@ccpgames-carbon

ccpgames-carbon commented Sep 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants