Repository navigation
fix: send the bundle and the runtime in apps:devices:probe - #279
Merged
Merged
Conversation
apps:devices:probeapps:devices:probe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps:devices:probechecks whether a device would receive a live update. Two things made its answer differ from what the device itself gets.The bundle of the device. The command did not tell the update check which bundle the device runs. So the check answered as if the device ran the bundle built into the app, and the command printed "Update available" also for a device that already runs the latest bundle.
--jsonoutput is unchanged. It prints the answer of the check, so it does not tell "up to date" from "update available".The runtime of the app. The command sent no runtime, so the check assumed Capacitor and rejected the probe of a Cordova or an Electron app. The command now loads the app and sends its type as the runtime.
Tested
Two tests for the command: the request carries the bundle of the device and the runtime of the app, and the JSON output is the unchanged answer.