Skip to content

fix: send the bundle and the runtime in apps:devices:probe - #279

Merged
robingenz merged 2 commits into
mainfrom
fix/devices-probe-bundle-id
Nov 18, 2026
Merged

robingenz merged 2 commits into
mainfrom
fix/devices-probe-bundle-id

Conversation

@robingenz

@robingenz robingenz commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

apps:devices:probe checks whether a device would receive a live update. Two things made its answer differ from what the device itself gets.

The bundle of the device. The command did not tell the update check which bundle the device runs. So the check answered as if the device ran the bundle built into the app, and the command printed "Update available" also for a device that already runs the latest bundle.

  • The command now sends the bundle the device runs.
  • In text mode it prints "This device is up to date." when the answer is the bundle the device already runs.
  • The --json output is unchanged. It prints the answer of the check, so it does not tell "up to date" from "update available".

The runtime of the app. The command sent no runtime, so the check assumed Capacitor and rejected the probe of a Cordova or an Electron app. The command now loads the app and sends its type as the runtime.

Tested

Two tests for the command: the request carries the bundle of the device and the runtime of the app, and the JSON output is the unchanged answer.

@robingenz robingenz changed the title fix: send the bundle a device runs in apps:devices:probe fix: send the bundle and the runtime in apps:devices:probe Nov 18, 2026
@robingenz
robingenz merged commit 5381e0a into main Nov 18, 2026
3 checks passed
@robingenz
robingenz deleted the fix/devices-probe-bundle-id branch November 18, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant