fix(calendar): suppress duplicate projections of recorded recurrence moves - #2319
Merged
callumalpass merged 2 commits intoSep 13, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rescheduled recurring task can appear at its new scheduled date and again at its original rule date, even when its original-date marker is already stored on the task.
Exclude pending and historical moved original dates from rule-generated projections. Preserve those fields through Bases conversion even before its task cache is warm, and include them in mapped calendar refresh signatures. The explicit completed/skipped history pass remains intact, so requesting history still shows recorded occurrences. This change only reads existing metadata; it does not change schedules, recurrence rules, completion attribution or undo.
Validation: all 12 recurring-instance visibility and calendar-signature tests pass, including moved placement, later weekly occurrences, and preserved history. ESLint, TypeScript/build checks, and a disposable-vault plugin reload passed. Reopening the calendar with the recorded marker shows the moved occurrence only once.
Known limitation: fresh native tasks with no Google Calendar projection metadata do not currently record an original occurrence when their scheduled date changes. A fresh weekly Saturday task (
DTSTART:20260912;FREQ=WEEKLY;BYDAY=SA), initially scheduled for 12 September, moved throughtaskService.updatePropertyto 11 September, still appears on both days. The file contains the new schedule but no original-date marker. This was reproduced with calendar export disabled. The tracking predicate ingoogleCalendarRecurringExceptions.tsrequires existing projection metadata. This PR deliberately fixes rendering when identity is known; a broader native fix needs provider-independent occurrence-move identity, with completion and undo tested against it, rather than inferring identity from the displayed date.