Skip to content

chore(deps): Pin GitHub Actions to specific SHAs - #84

Merged
Scotchester merged 1 commit into
mainfrom
chore/pin-actions
Oct 29, 2026
Merged

Scotchester merged 1 commit into
mainfrom
chore/pin-actions

Conversation

@Scotchester

Copy link
Copy Markdown
Member

Rather than merging #80 and #82

jgravois
jgravois previously approved these changes Oct 29, 2026

@jgravois jgravois left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like an improvement to me!

if: github.actor == 'dependabot[bot]' || github.actor == 'pre-commit-ci[bot]'
steps:
- uses: actions/add-to-project@main
- uses: actions/add-to-project@5afcf98fcd03f1c2f92c3c83f58ae24323cc57fd # v2

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if only they'd tag v2.0.1!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. There are a lot of other things that have been merged, too… do you think we should maybe use the latest commit on main?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i feel better about sticking with v2.0.0 for now, but if they still haven't pushed another tag by the end of the year, i could get behind pinning to the SHA of our choice. 😈

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, amended those comments to # v2.0.0, please review once more!


- name: Deploy docs
uses: mhausenblas/mkdocs-deploy-gh-pages@master
uses: mhausenblas/mkdocs-deploy-gh-pages@a31c6b13a80e4a4fbb525eeb7a2a78253bb15fa5 # does not do versioned releases

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll be able to test this action e2e when you tag an RC for #83. that seems 'good enough' to me.

@jgravois jgravois left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈🌈

@Scotchester
Scotchester merged commit 1f4f1f8 into main Oct 29, 2026
1 check passed
@Scotchester
Scotchester deleted the chore/pin-actions branch October 29, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants