Skip to content

docs(matrix): cachekit-ts passes reject_envelope_slots_overclaim in both lanes (LAB-8577) - #190

Merged
27Bslash6 merged 1 commit into
mainfrom
docs/LAB-8577-matrix-ts-slots-overclaim
Oct 9, 2026
Merged

27Bslash6 merged 1 commit into
mainfrom
docs/LAB-8577-matrix-ts-slots-overclaim

Conversation

@27Bslash6

Copy link
Copy Markdown
Contributor

The TypeScript Wire format cell in sdk-feature-matrix.md no longer lists reject_envelope_slots_overclaim as an expected failure. Since cachekit-io/cachekit-ts#232 (merged, unreleased), the SDK refuses it with the envelope pre-scan's own error in both lanes.

  • TypeScript Wire format cell: the ⚠️ clause describing the vector as a type error at element 1, held as an expected failure naming WIRE-9, is replaced. It now says the vector passes in both lanes: the SDK's header walk keeps a running total of declared slots and refuses the vector before element 1's type check and before core sees the bytes. The cell's "flips when" condition no longer names that expected failure, and names only the core release that carries the envelope pre-scan. The leading "Compliant except the envelope pre-scan" clause is unchanged.
  • Note ¹⁶: cachekit-ts now holds one gap as an expected failure, the temporal sentinels, where it held two.
  • changelog.d/20261010_lab-8577.md records the change. conformance/sdks.json does not change, because no fixture copy moved, and conformance/coverage.md is still current.

Checked locally: tools/conformance.py check --base origin/main, tools/check-version-floors.py and tools/test_changelog_collect.py all pass.

Closes LAB-8577

…oth lanes

The TypeScript Wire format cell no longer records the vector as an
expected failure: cachekit-ts#232 makes the SDK's header walk refuse it with
the envelope pre-scan's own error (WIRE-9). Note 16 now gives cachekit-ts one
expected-failure gap, the temporal sentinels.
@kodus-27b

kodus-27b Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the `@kody start-review` command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Providing Context (Files & MCPs)

Add these hints in your PR description (or a comment) to unlock deeper checks:

  • Ticket / Acceptance Criteria: `Refs: ABC-123` (Linear/Jira/Asana/ClickUp/Trello) or a direct ticket link.
  • Bugfix Validation: a Sentry/Datadog/Bugsnag event link (or paste the stack trace/error message).
  • Endpoint Risk: mention the route (e.g., `POST /api/payments`) or controller/action name.
  • Attach a repo file as context: use an explicit marker like `@file:docs/guide.mdx#L10-L50` (replace with your real path).
  • API Contract Docs: include `@file:openapi.yaml` or `@file:swagger.json` when changing routes/schemas.
  • Definition of Done / Standards: include `@file:DOD.md` or `@file:CONTRIBUTING.md` if your repo has them.
  • Design System Source of Truth: include `@file:ui/index.ts` (replace with your DS entrypoint path).
  • Feature Flags: include the flag key/name and `@file:flags.ts` / `@file:config.json` (and optionally the PostHog flag name).
  • Edge/CDN Rules: link the Cloudflare rule/zone or describe the intended redirect/header behavior.
  • Attach an MCP tool output: use `@mcp<provider|tool>` (replace with an installed MCP provider + tool, e.g., `@mcp<sentry|events.search>`).
Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: cachekit-io/protocol/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 29e2cfe4-2e91-4df9-8168-862456403d7d

📥 Commits

Reviewing files that changed from the base of the PR and between f8c8382 and 9a2b85a.


📒 Files selected for processing (2)
  • changelog.d/20261010_lab-8577.md
  • sdk-feature-matrix.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



Summary by CodeRabbit

  • Documentation
    • Updated the TypeScript wire-format compliance notes to show that envelopes declaring more slots than allowed are rejected in both Node and Workers.
    • Updated the expected-failure count from two to one; the remaining failure relates to temporal sentinels.

Walkthrough

The feature matrix and changelog record that TypeScript passes the reject_envelope_slots_overclaim vector in both test lanes. They describe rejection during the envelope pre-scan and update the expected-failure count.

Changes

TypeScript wire-format status

Layer / File(s) Summary
Record wire-format compliance
sdk-feature-matrix.md, changelog.d/20261010_lab-8577.md
The feature matrix records the vector as passing in both lanes. The changelog updates the release condition and expected-failure count. Both describe rejection before element type checking or core decoding.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 9a2b8

The updated conformance status is supported by tests in both lanes, with no identified PR-introduced issue remaining.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly identifies the documentation change: cachekit-ts now passes reject_envelope_slots_overclaim in both lanes. It is specific and aligned with the main change.
Description check Passed The description directly explains the matrix update, the cachekit-ts#232 behaviour, the expected-failure count, and the validation checks. It is related to the changeset.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@27Bslash6
27Bslash6 merged commit 6b3fb94 into main Oct 9, 2026
5 checks passed
@27Bslash6
27Bslash6 deleted the docs/LAB-8577-matrix-ts-slots-overclaim branch October 9, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant