Skip to content

chore(conformance): record cachekit-rs's file-backend 1.2.0 and python-frame copies (LAB-8444) - #182

Merged
27Bslash6 merged 2 commits into
mainfrom
lab-8444-rs-file-frame-copies
Oct 8, 2026
Merged

27Bslash6 merged 2 commits into
mainfrom
lab-8444-rs-file-frame-copies

Conversation

@27Bslash6

@27Bslash6 27Bslash6 commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Records cachekit-rs's new fixture copies from cachekit-io/cachekit-rs#158, merged as b5fb2a6. The record changes no spec text and no vector.

  • conformance/sdks.json: cachekit-rs moves to commit b5fb2a67392ce8dfd4dc199ad7ec7233a661d43b. file-backend.json moves to 1.2.0 (b7b0c519…12af4), and python-frame.json (1210a2cd…1770a) is added. I checked every hash against the files at that commit.
  • conformance/coverage.md: regenerated. For cachekit-rs, FILE-2, IOP-19 and IOP-20 become covered. FILE-1, FILE-3, FILE-4, ENC-5, ENC-10 and WIRE-21 become partial (gap). No other SDK's status moves.
  • sdk-feature-matrix.md:
    • The rs cell of Test vectors in CI records the two copies and what cachekit-rs drives through them.
    • Note ¹⁶ records the two copies.
    • The rs cell of Temporal sentinels adds that main revives none either, and that cachekit-rs vendors no wire-format.json.
    • Note ¹⁵ now says cachekit-rs decodes the bare ByteStorage envelope, cachekit-ts's container. That breaks WIRE-21 for that container. coverage.md counts rs's WIRE-21 vectors as held because they are vendored, not because rs refuses them all, so the matrix says so where a reader will see it.
  • conformance/requirements.json: WIRE-21's gap now names cachekit-rs's bare-envelope decode, so closing the vector gap later cannot mark cachekit-rs covered for a rule it breaks.
  • Storage container row: the cachekit-rs cell carries ⚠️ for the bare-envelope decode, and the Test vectors clause uses the row's "⚠️ except" form, so the violation is visible in the cells and not only in note ¹⁵. Note ¹⁵ also names crates.io 0.10.0's auto-mode CK-frame decode as a second WIRE-21 violation.
  • changelog.d/20261008_lab-8444.md: the release-note fragment.

python3 tools/conformance.py check --base origin/main, tools/test_conformance.py (284 cases), tools/test_changelog_collect.py, check-spec-duplication.py and check-version-floors.py pass locally.

The open cachekit-ts record (cachekit-io/protocol#178) edits the same note ¹⁶ sentences. Whichever lands second rebases and regenerates.

Closes LAB-8444

…n-frame copies

sdks.json reads cachekit-rs at b5fb2a6, which vendors file-backend.json 1.2.0 and, for the first time, python-frame.json. coverage.md is regenerated. The feature matrix records both copies, that cachekit-rs decodes the bare ByteStorage envelope (a WIRE-21 violation the coverage status does not show), and why it vendors no wire-format.json.
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: cachekit-io/protocol/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 55b93dc2-edfd-4a67-b8a6-ccac8301648c
📥 Commits

Reviewing files that changed from the base of the PR and between fe0202a and 6fa1fe7.

📒 Files selected for processing (5)
  • changelog.d/20261008_lab-8444.md
  • conformance/coverage.md
  • conformance/requirements.json
  • conformance/sdks.json
  • sdk-feature-matrix.md
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kodus-27b

kodus-27b Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the `@kody start-review` command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Providing Context (Files & MCPs)

Add these hints in your PR description (or a comment) to unlock deeper checks:

  • Ticket / Acceptance Criteria: `Refs: ABC-123` (Linear/Jira/Asana/ClickUp/Trello) or a direct ticket link.
  • Bugfix Validation: a Sentry/Datadog/Bugsnag event link (or paste the stack trace/error message).
  • Endpoint Risk: mention the route (e.g., `POST /api/payments`) or controller/action name.
  • Attach a repo file as context: use an explicit marker like `@file:docs/guide.mdx#L10-L50` (replace with your real path).
  • API Contract Docs: include `@file:openapi.yaml` or `@file:swagger.json` when changing routes/schemas.
  • Definition of Done / Standards: include `@file:DOD.md` or `@file:CONTRIBUTING.md` if your repo has them.
  • Design System Source of Truth: include `@file:ui/index.ts` (replace with your DS entrypoint path).
  • Feature Flags: include the flag key/name and `@file:flags.ts` / `@file:config.json` (and optionally the PostHog flag name).
  • Edge/CDN Rules: link the Cloudflare rule/zone or describe the intended redirect/header behavior.
  • Attach an MCP tool output: use `@mcp<provider|tool>` (replace with an installed MCP provider + tool, e.g., `@mcp<sentry|events.search>`).
Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

kodus-27b[bot]
kodus-27b Bot previously approved these changes Oct 8, 2026
…ix cells and the index gap

The Storage container rs cell and the Test vectors rs clause now carry the bare-envelope decode as a warning, not only note 15. Note 15 names crates.io 0.10.0's auto-mode CK-frame decode as a second violation. WIRE-21's gap in requirements.json names the bare-envelope decode, so closing the vector gap cannot mark cachekit-rs covered. Note 16 keeps only the inventory; the changelog states the conditions the refusal holds under.
@kodus-27b

kodus-27b Bot commented Oct 8, 2026

Copy link
Copy Markdown

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the `@kody start-review` command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Providing Context (Files & MCPs)

Add these hints in your PR description (or a comment) to unlock deeper checks:

  • Ticket / Acceptance Criteria: `Refs: ABC-123` (Linear/Jira/Asana/ClickUp/Trello) or a direct ticket link.
  • Bugfix Validation: a Sentry/Datadog/Bugsnag event link (or paste the stack trace/error message).
  • Endpoint Risk: mention the route (e.g., `POST /api/payments`) or controller/action name.
  • Attach a repo file as context: use an explicit marker like `@file:docs/guide.mdx#L10-L50` (replace with your real path).
  • API Contract Docs: include `@file:openapi.yaml` or `@file:swagger.json` when changing routes/schemas.
  • Definition of Done / Standards: include `@file:DOD.md` or `@file:CONTRIBUTING.md` if your repo has them.
  • Design System Source of Truth: include `@file:ui/index.ts` (replace with your DS entrypoint path).
  • Feature Flags: include the flag key/name and `@file:flags.ts` / `@file:config.json` (and optionally the PostHog flag name).
  • Edge/CDN Rules: link the Cloudflare rule/zone or describe the intended redirect/header behavior.
  • Attach an MCP tool output: use `@mcp<provider|tool>` (replace with an installed MCP provider + tool, e.g., `@mcp<sentry|events.search>`).
Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

@27Bslash6
27Bslash6 merged commit 642c0d6 into main Oct 8, 2026
5 checks passed
@27Bslash6
27Bslash6 deleted the lab-8444-rs-file-frame-copies branch October 8, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant