Repository navigation
test(interop): pin read_every_path paths and scope bare-envelope README claim (LAB-8602) - #159
Conversation
…ME claim The CK-frame sweep now asserts the exact path names read_every_path returns, so dropping a read path fails the sweep instead of silently shrinking it. The README's bare-envelope sentences now say they hold for a client without encryption; an encrypting client fails at decrypt. Test doc comments now describe what the tests do, and plain_reads_reject_a_plaintext_entry also covers interop_get_swr.
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. Summary by CodeRabbit
WalkthroughDocumentation now describes bare ByteStorage envelope decoding for encrypted and unencrypted clients. Tests add an ChangesBare envelope read paths
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The PR clarifies documented read behavior and strengthens coverage of the affected paths; no material user-facing or operational risk is apparent. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-ups to #158. Tests and README only: no library change.
every_ck_frame_in_the_file_is_refused_on_every_pathnowassert_eq!s the path namesread_every_pathreturns against the five expected ones (serializer::deserialize,interop::deserialize,CacheKit::get,CacheKit::interop_get,CacheKit::interop_get_swr). Before, dropping a push fromread_every_pathwould shrink the sweep silently; checked by removing theCacheKit::getpush locally, which makes the sweep fail.EnvelopedValuecomment citesdefault_saas_write_msgpack_bytestorage_bin's payload (the bytes the bare-envelope vector carries). The module doc mentions the positional-match assertion the bare-envelope test already makes. Theread_every_pathdoc says "every read path of a client without encryption" and "this SDK writes".plain_reads_reject_a_plaintext_entryalso checks thatinterop_get_swrreturnsEncryptionon a plaintext entry.cargo fmt --check,cargo clippy --all-targets -D warningsandcargo test -p cachekit-rspass locally.Closes LAB-8602