Repository navigation
Preserve held sneak while selecting a break target - #5151
Merged
Merged
Conversation
EvModder
marked this pull request as ready for review
October 21, 2026 03:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuilderProcess keeps sneak held while breaking, so that a block reachable only from the sneaking eye height stays reachable (the "really horrible bug" comment). The guard checks
isCrouching(), but that flag is updated inaiStepand can still be false on a tick where sneak is already held and the pose is alreadyCROUCHING.When that happens, the builder releases sneak right after selecting a target that is only visible while sneaking. Standing up loses the target, so it goes to place something, sneaks again, and repeats. The result is a break/place aiming loop with no clicks and no movement.
I kept running into this bug on 26.2 & 1.21.4 while replacing a section of blocks in a floor, where it would get stuck relatively oten. Applying this one condition to the running client repeatedly resolved a stuck build.
Related: #5128 fixes a different builder stall (break goals that are already satisfied). The two don't overlap.