Skip to content

allow baritone to walk on waterlogged topslabs/stairs - #3326

Draft
wagyourtail wants to merge 3 commits into
cabaletta:1.17.1from
wagyourtail:fixwatertopslab
Draft

wagyourtail wants to merge 3 commits into
cabaletta:1.17.1from
wagyourtail:fixwatertopslab

Conversation

@wagyourtail

@wagyourtail wagyourtail commented Mar 16, 2022 •

Copy link
Copy Markdown
Collaborator

should this apply to anything else?

it appears to have an issue with going down waterlogged stairs and I'm not sure why...

https://cdn.discordapp.com/attachments/822210907173421116/953478457252274256/Peek_2022-03-15_19-20.gif

@StealthyPony

StealthyPony commented Mar 16, 2022 •

Copy link
Copy Markdown

Also affected:
Trapdoor

@wagyourtail

Copy link
Copy Markdown
Collaborator Author

in my testing it appeared to work with trapdoor...

@StealthyPony

Copy link
Copy Markdown

Odd, when I did the test with trapdoors it chose swimming through the water over walking on the trapdoors
If I surrounded the starting block with trapdoors it failed to path to the goal completely, giving the "No path found :(" message
My starting and goal blocks are both full blocks, perhaps that had something to do with it

@leijurv

leijurv commented Mar 31, 2022 •

Copy link
Copy Markdown
Member

I remember testing this in late 2019-ish, and making stairs canWalkOn made it do stupid stuff with failing parkour jumps. I think this needs a check to see if the stair is upside down. Right side up stairs shouldn't be canWalkOn if I remember correctly?

@EvModder

Copy link
Copy Markdown
Contributor

I opened #5152 against 1.21.4, covering the same (general) case. It adds isWaterloggedSolidTop (wogged, with a sturdy top face) and exempts some blocks from water checks in canWalkOnBlockState, from the water-landing check in MovementDescend, and from the assumeWalkOnWater checks in MovementPillar and MovementParkour.

So falls onto a wogged top slab are also kept, with fall damage, instead of being treated as impossible water landings.

It doesn't change stairs, so the parkour concern above about right-side-up stairs is still a thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants