Repository navigation
Examples tab: accurate features and tags, and a search - #43
Merged
Merged
Conversation
…earch
The tab's pills and its filter disagreed: a card showed the view kinds its
document draws plus its tags, but the chips filtered on tags alone, so an
example drawing a survival view was missing under "survival". And the tags
themselves had drifted from the documents.
lib/example-features.ts is now the one source for what an example is about:
- views: the kinds its document draws, read from doc.views
- topics: derived ones first ("federation" when its cohorts span more than
one study, "custom-data" when it brings uploads), then its own tags
The tab, its filter and the assistant's list_examples tool all read it.
Tags are now topics only. Removed tags that named a view the document lacks
(oncoprint on the colorectal workup, compare on pathways/enrichment/
signatures, survival on Cox/risk model/incidence, table on the patient
tables, clinical and attrition where there is no such view), "federation" on
three single-study examples (now "federable"), and spellings of one tag
two ways (OQL/oql, gene-set/gene-sets, lines-of-therapy/treatment-lines,
timeline vs the timeline view kind -> timeline-events).
Removed the second "A survival risk model from mutated genes in lung cancer":
a stale copy reinserted by 34e2116; the Table 1 change updated only the
first. Two cards with one title shared a React key. Fixed the colorectal
workup's note, which promised an oncoprint the document does not draw.
Search: every word of the query must appear in the title, demonstrates,
note, pills or studies, ignoring case, hyphens and spaces. It combines with
the chip filter; chips are grouped as views / topics, their counts follow
the search, and an empty result says so with ways out. The box keeps its own
draft and hands it to the page after a pause, so typing re-renders the tab,
not the page; search and filter survive a tab switch (use-library).
Verified: test/example-features.test.ts (unique titles, no tag naming a view
kind, no hand-written derived tag, no tag spelled two ways, search rules);
a new e2e check that the survival chip plus a search shows exactly the
expected cards; GATE_PORT=4109 scripts/gate.sh passes (262 PASS, 0 FAIL,
docs/dsl.md in sync, example counts unchanged).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JqkKwtvKACvUPwmbbJzrjv
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Examples tab's pills and its filter disagreed, and the tags had drifted from the documents. This fixes both and adds a search.
What was wrong
survival.oncoprintwas on the colorectal workup, and its note promised an oncoprint it doesn't draw.comparewas on pathways/enrichment/signatures,survivalon Cox/risk model/incidence, andtableon the patient tables.federationwas on three single-study examples.OQL/oql,gene-set/gene-sets,lines-of-therapy/treatment-lines, and thetimelinetag vs. thetimelineview kind.What changed
lib/example-features.tsis now the one source for the tab, its filter and the assistant'slist_examplestool:doc.views.federation(cohorts span more than one study) andcustom-data(bundled uploads) are derived from the document.tagsnow hold topics only.docs/dsl.md.Verification
test/example-features.test.tschecks for unique titles, no tag naming a view kind, no hand-written derived tag, no tag spelled two ways, and the search rules.GATE_PORT=4109 scripts/gate.sh: 262 PASS, 0 FAIL.docs/dsl.mdis in sync and the example counts are unchanged.🤖 Generated with Claude Code
https://claude.ai/code/session_01JqkKwtvKACvUPwmbbJzrjv