Conversation
adamrk
force-pushed
the
abk/net-p3
branch
2 times, most recently
from
September 22, 2026 14:04
b25f493 to
3ec7de0
Compare
adamrk
commented
Sep 22, 2026
Comment on lines
+106
to
+109
| let (input, _receive_result) = socket.receive(); | ||
| let (output, receiver) = wasip3::wit_stream::new(); | ||
| let _send_result = socket.send(receiver); | ||
| Ok(TcpStream::new(input, output, socket)) |
Contributor
Author
There was a problem hiding this comment.
We could save _receive_result and _send_result in the TcpStream and add a graceful shutdown method which checks them. But that should probably be a separate follow up.
adamrk
marked this pull request as ready for review
September 22, 2026 14:14
pchickey
added this pull request to stack #165
September 25, 2026 18:20
pchickey
approved these changes
Oct 1, 2026
pchickey
left a comment
pchickey
left a comment
Contributor
There was a problem hiding this comment.
I'm a little torn whether to ask you to decompose the tcp_listener, tcp_stream, and udp.rs in the sys style - theyre not ideal the way they are, but they at least have more in common than elsewhere. I am OK landing it like this and if we need to change the way they're factored down the line we always can come back to it.
Contributor
Author
|
No problem, I just moved it to use the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #161
Based on #162