Repository navigation
Select execution runtimes on each worker - #78
Merged
Merged
Conversation
Share release and binary selectors between import and run. Keep legacy readers, derive Namespace setup from the worker, and retain exact-version caches. Amp-Thread-ID: https://ampcode.com/threads/T-3784262c-5fe0-4e2f-99ad-8443940d75a8 Co-authored-by: Amp <amp@ampcode.com>
Count real acquisition requests during same-worker replay without logging credentials. Keep this opt-in proof distinct from unchanged-emission and scheduler retry evidence. Amp-Thread-ID: https://ampcode.com/threads/T-3784262c-5fe0-4e2f-99ad-8443940d75a8 Co-authored-by: Amp <amp@ampcode.com>
Use independent failure controls, preserve Python arguments with PowerShell 7, and exercise absent-version and optional custom-digest selectors. Amp-Thread-ID: https://ampcode.com/threads/T-3784262c-5fe0-4e2f-99ad-8443940d75a8 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-3784262c-5fe0-4e2f-99ad-8443940d75a8 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Why
Import and execution currently select runtimes differently: import accepts
versionorbinary, but execution requires a platform, URL and digest selected by its caller. This couples generated jobs to importer-side executable selection and setup assumptions.What
Share the existing runtime selector between import and execution. Each host selects its own asset; absent version or
latestuses the Agent API release endpoint. Complete exact-version caches need no lookup, including after a clean checkout.A
binarymap can instead provide HTTPS URLs forlinux/amd64,linux/arm64,darwin/arm64andwindows/amd64, with optional#sha256=fragments and no release lookup. Windows remains execution-only.Use the worker's
NSC_INSTANCE_IDfor Namespace setup rather than importer routing. Keep hosted-tool-cache as an explicit top-level option, and preserve published legacy runtime/event readers and their setup options.Companion: buildkite-gha#682. Release this consumer before the companion CLI.