Repository navigation
Slack agent: treat passing mentions as mentions, allow reaction-only answers - #1391
Conversation
…answers "and this slack has @uploads.sh installed" reached the model as "and this slack has installed" under a "Question:" label, and the prompt assumed every mention wanted a file search, so it searched and described an unrelated file. - questionText keeps a mid-sentence mention as "@uploads.sh"; only a leading one is dropped. - The prompt says not every mention is a request: statements, thanks and questions about the app get a short answer or a reaction, no search. It also says to only talk about files it's showing. - `reply` takes an optional reaction from a short list. With empty text the mention gets that reaction and nothing is posted. Fixes #1390 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeLbkgKTCzrsVDA3JKewJz
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 2
🚫 Excluded labels (none allowed): 1
Please check the settings in the CodeRabbit UI or the
 |
Requested by Zach · project thread
Fixes #1390.
"and this slack has @uploads.sh installed" reached the model as
Question: and this slack has installed, and the prompt assumed every mention wanted a file search. So it searched, then described an unrelated FAQ screenshot it didn't show.Changes
questionText(apps/slack/src/mentions.ts): only a leading mention of the app is dropped. A mention later in the sentence becomes@uploads.sh, so the subject stays.apps/slack/src/agent.ts): the user message is labeledMessage:instead ofQuestion:. The prompt now says not every mention is a request. Statements, thanks and questions about the app get a short answer or a reaction, with no search. It also says to only talk about files it's showing.replytakes an optionalreaction(+1,white_check_mark,raised_hands,heart,tada). With empty text, the mention gets that reaction and nothing is posted. With text, it gets both. Reactions outside the list are dropped. The bot already hasreactions:writefor 👀.Tests
pnpm exec vitest runinapps/slackpasses (123 tests), andtsc --noEmitis clean.reactions.addwith nochat.postMessage).Generated by Claude Code