feat: Massed Compute - #151
Merged
Merged
Conversation
drewmalin
marked this pull request as ready for review
August 27, 2026 17:58
| const ( | ||
| CloudProviderID = "massedcompute" | ||
| DefaultAPIURL = "https://vm.massedcompute.com/api/v1" | ||
| massedComputeLocation = "massedcompute" // Massed Compute does not support location selection, so report all locations as "massedcompute" |
| const ( | ||
| CloudProviderID = "massedcompute" | ||
| DefaultAPIURL = "https://vm.massedcompute.com/api/v1" | ||
| massedComputeLocation = "massedcompute" // Massed Compute does not support location selection, so report all locations as "massedcompute" |
| return instance, nil | ||
| } | ||
|
|
||
| func validateCreateInstanceAttrs(attrs v1.CreateInstanceAttrs) error { |
Contributor
There was a problem hiding this comment.
do they have a max chars limit for name?
Contributor
Author
There was a problem hiding this comment.
I tripled the typical name and didn't see a validation error (> 200 characters), so we should be good.
| } | ||
|
|
||
| func (c *MassedComputeClient) listRunningInstances(ctx context.Context) ([]openapi.RetrieveAllRunningInstancesV1RunningInstancesInner, error) { | ||
| resp, httpResp, err := c.client.InstancesAPI.InstanceGet(ctx).Execute() |
Comment on lines
+88
to
+89
| memoryBytes := v1.NewBytes(v1.BytesValue(int32Value(specs.MemoryGib)), v1.Gibibyte) | ||
| storageBytes := v1.NewBytes(v1.BytesValue(int32Value(specs.StorageGb)), v1.Gigabyte) |
Contributor
There was a problem hiding this comment.
why does everyone make this so god damn hard
patelspratik
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some odd things:
I've raised these with their team, so in the future we will need to consume fixes.