Repository navigation
Preserve instants when serializing timezone-aware XML datetimes - #172
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The XML generator formats every date/datetime with a
Zsuffix. For aware datetimes with nonzero offsets, it uses the local wall-clock fields without converting to UTC, changing the represented instant by the offset.Convert aware datetimes to
datetime.timezone.utcbefore formatting. Preserve existing UTC, naive-datetime, date-only, and second-precision behavior. No API requests or signatures change.Five public
XmlUtilround-trip/control cases cover positive and negative offsets, a UTC date boundary, UTC, naive datetimes, and date-only values. Two regressions fail before the change and three controls pass. Afterward, all 567 unit tests pass. Full package compile andgit diff --checkpass. Hosted gateway integration tests and the full Python/OS matrix were not run.Checklist
python3 -m unittest discover tests/unit)