Skip to content

Disable C4848 around [[msvc::no_unique_address]]; only use it on msvc… #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jzmaddock merged 1 commit into from
Sep 18, 2026
Merged

Disable C4848 around [[msvc::no_unique_address]]; only use it on msvc… #559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions include/boost/config/compiler/visualc.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,13 @@
#define BOOST_NO_CXX17_AUTO_NONTYPE_TEMPLATE_PARAMS
#endif

#if _MSC_FULL_VER >= 192829913
// Works with /std:c++14 and /std:c++17, and performs optimization
#define BOOST_ATTRIBUTE_NO_UNIQUE_ADDRESS [[msvc::no_unique_address]]
#if _MSC_VER >= 1930
// [[no_unique_address]] is a no-op under MSVC
// [[msvc::no_unique_address]] applies the optimization, and works with /std:c++14 and /std:c++17
// Even though it's supported from 19.28 onwards, we only enable it from 19.30, so that a minor
// compiler update doesn't change ABI
#define BOOST_ATTRIBUTE_NO_UNIQUE_ADDRESS \
__pragma(warning(push)) __pragma(warning(disable: 4848)) [[msvc::no_unique_address]] __pragma(warning(pop))
#endif

//
Expand Down