Repository navigation
fix: prevent startup crash on Apple M5 Macs - #80
Merged
Merged
Conversation
Darwin cgo builds of notecard and notehub segfault during init on Apple M5 chips in github.com/shoenig/go-m1cpu v0.1.x, pulled in through note-go and gopsutil/v3. Pin go-m1cpu v0.2.4, which fixes M5, M5 Pro and M5 Max handling and reports the correct CPU frequency. go-m1cpu v0.2.3+ requires Go 1.26, so the go directive moves from 1.25.0 to 1.26 in both modules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bucknalla
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notecardandnotehubcrash with a segfault at startup on Apple M5 Macs (reproduced on an M5 Pro, macOS 27.2, including the current Homebrew cask). The crash comes fromgithub.com/shoenig/go-m1cpuv0.1.x, pulled in throughnote-go→gopsutil/v3; it only affects darwin builds with cgo enabled, which is how releases are built.This pins go-m1cpu v0.2.4, which fixes M5, M5 Pro and M5 Max handling and reports the correct CPU frequency (used for
cpu_mhzin note-go's user agent). go-m1cpu v0.2.3+ requires Go 1.26, so thegodirective moves from1.25.0to1.26ingo.modandlib/go.mod.This change was accidentally pushed straight to master as 2a8252d and reverted in 7fede9e; this PR resubmits it for review.
Testing
notecardandnotehubstart normally on the M5 Pro; the same binaries built with v0.1.7 segfault.note-go itself still pins the crashing version. That has been handed off to the note-go/hub owners; this pin overrides it for note-cli in the meantime.
🤖 Generated with Claude Code