Skip to content

Support signal frame unwinding on AArch64 - #348

Open
K0u1e wants to merge 1 commit into
bloomberg:mainfrom
K0u1e:support_signal_frame_unwind_on_aarch64
Open

Support signal frame unwinding on AArch64#348
K0u1e wants to merge 1 commit into
bloomberg:mainfrom
K0u1e:support_signal_frame_unwind_on_aarch64

Conversation

@K0u1e

@K0u1e K0u1e commented Aug 14, 2026

Copy link
Copy Markdown

#341

Describe your changes
add patch for elfutils to unwind signal frame on aarch64

Testing performed
run test in issue and see

    (C) File "./Modules/clinic/posixmodule.c.h", line 5649, in os_kill.lto_priv.0 (/usr/local/python3.14t/lib/libpython3.14t.so.1.0)
    (C) File "./Modules/posixmodule.c", line 9666, in os_kill_impl (inlined) (/usr/local/python3.14t/lib/libpython3.14t.so.1.0)
    (C) File "../sysdeps/unix/syscall-template.S", line 120, in kill (/usr/lib/aarch64-linux-gnu/libc.so.6)
    (C) File "???", line 0, in __kernel_rt_sigreturn ([vdso: 492437])
    (C) File "/usr/lib/aarch64-linux-gnu/libffi.so.8.1.2", line 0, in ??? (/usr/lib/aarch64-linux-gnu/libffi.so.8.1.2)
    (C) File "/usr/lib/aarch64-linux-gnu/libffi.so.8.1.2", line 0, in ??? (/usr/lib/aarch64-linux-gnu/libffi.so.8.1.2)
    (C) File "./Modules/_ctypes/callbacks.c", line 302, in closure_fcn (/usr/local/python3.14t/lib/python3.14t/lib-dynload/_ctypes.cpython-314t-aarch64-linux-gnu.so)
    (C) File "./Modules/_ctypes/callbacks.c", line 210, in _CallPythonObject (/usr/local/python3.14t/lib/python3.14t/lib-dynload/_ctypes.cpython-314t-aarch64-linux-gnu.so)

Additional context
https://codebrowser.dev/llvm/libunwind/src/UnwindCursor.hpp.html#2810

@codecov-commenter

codecov-commenter commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.56%. Comparing base (1d399fa) to head (a46452e).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   77.63%   77.56%   -0.08%     
==========================================
  Files          57       57              
  Lines        6601     6611      +10     
  Branches      628      630       +2     
==========================================
+ Hits         5125     5128       +3     
- Misses       1476     1483       +7     
Flag Coverage Δ
cpp 77.56% <ø> (-0.08%) ⬇️
python 77.56% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godlygeek

godlygeek commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

OK, this looks like a small enough patch that I'd be willing to carry it in pystack for now, until this is addressed in elfutils proper.

@K0u1e would you mind amending your commit to add a Signed-off-by: line with your full name? See https://github.com/bloomberg/pystack/blob/main/CONTRIBUTING.md#contribution-licensing - we need that as an attestation that this code is yours, and that you're willing to offer it under the terms of the Apache 2 license we use.

If you amend your commit and push it up with that, I can take care of rebasing it and getting it past our lint checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants