fix(desktop): check access again when you select or pin an @ mention - #7196
Draft
loganj wants to merge 1 commit into
Draft
fix(desktop): check access again when you select or pin an @ mention#7196loganj wants to merge 1 commit into
loganj wants to merge 1 commit into
Conversation
loganj
force-pushed
the
fix/mention-picker-stack-5bd14d7a-4
branch
from
September 2, 2026 02:15
3916b7d to
d287d89
Compare
loganj
force-pushed
the
fix/mention-picker-stack-844abd33-3
branch
2 times, most recently
from
September 2, 2026 16:06
01d4c85 to
8d9aded
Compare
loganj
force-pushed
the
fix/mention-picker-stack-5bd14d7a-4
branch
from
September 2, 2026 16:06
d287d89 to
a09ca69
Compare
Package existing reviewed repairs in the authorized seven-slice dependency stack. Preserved model A; experiment excluded. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <loganj@squareup.com>
loganj
force-pushed
the
fix/mention-picker-stack-5bd14d7a-4
branch
from
September 2, 2026 16:33
a09ca69 to
1a8a942
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
An
@choice could remain on screen after access changed or you left the channel. Selecting that old choice could insert a mention or enable automatic mentions. Buzz now checks the selected recipient again before it changes your draft.The same check protects Automatically mention, the pin control that adds an agent to later messages in the conversation. If Buzz rejects a choice, it leaves your draft and automatic mentions unchanged. You can still use Don't automatically mention to remove an agent after access is denied.
For a team choice, Buzz checks every recipient. It rejects the whole choice if the recipients changed or a recipient is no longer selectable. A renamed label, duplicate entry, or changed order cannot substitute another recipient.
This is draft PR 4 of 7, based on #7192. It protects the existing controls. It does not add new access labels or change access rules. It does not fix every case where the text or text cursor changes before selection. Search completion changes follow in #7197.
Related issue
Continues #7192 and the agent search and mention work in #7122 and #7124.
Testing
aa90290870119e0bef2ba5ebcb6ce92c069db388passed 165 affected Chromium cases, 161 focused tests and five bounded ordinary Enter/code-fence/multiline/emoji controls. Those results are reused for unaffected scope, not claimed as fresh whole-stack tests of this head. Historical 6,122 desktop tests predate the earlier Enter repair. Full repositoryjust ciwas not repeated.07fbd2ccb354c9ab81b018811f9799cbb00901a7. Head:1a8a942136a24e2c9dbba02c65f55e3485092826. Footprint including tests: 468 additions + deletions. Fixed stack root:802ba6170e57ac71d1ecfd6cf6fb12f02ecf910c.Exact-head CI follow-through (2026-09-02)
1a8a942136a24e2c9dbba02c65f55e3485092826: 14 successful jobs, 10 path/condition-skipped jobs. This is the path-scoped remote workflow result, not a new claim that every repository test ran.Origin discussion: Buzz channel
8dcd7afb-0193-4a3e-8ae9-72838de89a1d; original source channelf7a9536a-1738-4bad-a888-b3ea25010ef1. Draft only; no merge authority.