Skip to content

fix(cli): reject oversized emoji import stdin instead of truncating - #7119

Open
Chessing234 wants to merge 1 commit into
block:mainfrom
Chessing234:fix/cli-emoji-stdin-limit
Open

fix(cli): reject oversized emoji import stdin instead of truncating#7119
Chessing234 wants to merge 1 commit into
block:mainfrom
Chessing234:fix/cli-emoji-stdin-limit

Conversation

@Chessing234

Copy link
Copy Markdown
Contributor

Summary

  • Emoji import used .take(STDIN_MAX_BYTES) with no overflow check, so oversized stdin was silently truncated mid-JSON.
  • Match notes/mem: take limit+1 and return a usage error when exceeded.

Test plan

  • Normal small stdin import still works
  • Oversized stdin returns a clear usage error

@Chessing234
Chessing234 requested a review from a team as a code owner August 31, 2026 17:07
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is bc006f67087b049e2f9c4d8a2f26faceff628225...5b662d9ed7cfa5f44e6578925704842960024638.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 5b662d9ed7cfa5f44e6578925704842960024638 to authorize a new review.
Any previous review applies only to its recorded range.

notes/mem already error when stdin exceeds the take limit; emoji import
silently truncated mid-JSON.

Signed-off-by: Taksh <takshkothari09@gmail.com>
@Chessing234
Chessing234 force-pushed the fix/cli-emoji-stdin-limit branch from 85e31e3 to 5b662d9 Compare August 31, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant