Repository navigation
tools: render required capabilities in the step reference (#347) - #349
Merged
Merged
Conversation
…ce generator (#347) Get-IdleStepRequiredCapabilities prefixed the already-qualified step type with 'IdLE.Step.', so the catalog lookup never matched and no step page listed its required capabilities. Add a test that runs the generator and checks every step with declared RequiredCapabilities against its generated page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Verdict: PASS The one-line lookup fix is correct, the regenerated references match the generator output, and the new regression test covers the bug. No findings. |
Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The step reference generator never rendered a step's required capabilities.
Get-IdleStepRequiredCapabilitiesprefixed the already-qualified step type withIdLE.Step., so the catalog lookup (IdLE.Step.IdLE.Step.DisableIdentity) never matched and returned@().$catalog[$StepType]directly (same asGet-IdleStepWithKeyRows).docs/reference/steps/*: 15 step pages now list theirRequiredCapabilities(EmitEvent declares none).tests/Packaging/Generate-IdleStepReference.Tests.ps1: runs the generator in a separate pwsh process (it re-imports all IdLE modules) and checks every step with declaredRequiredCapabilitiesin the step packs'StepMetadataCatalog.psd1against its generated page. A guard test fails if no such steps are discovered.Testing
./tools/Invoke-IdlePesterTests.ps1: 1019 passed, 0 failed../tools/Invoke-IdleScriptAnalyzer.ps1: no findings.Closes #347
🤖 Generated with Claude Code