Repository navigation
Event types: IdLE.<Area>.<Event> naming and Level field (#325) - #345
Merged
Merged
Conversation
….* (#325) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…325) Failure events use Level 'Error'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- IdLE.Event gets a Level field (Information, Warning, Error); Context.EventSink.WriteEvent takes an optional fifth Level argument - Engine events renamed to IdLE.Run.*, IdLE.Step.*, IdLE.OnFailure.*; levels follow the outcome (failed -> Error, blocked -> Warning) - Information, Warning, Error and Custom are rejected as event types - Workflow-defined event types (PreconditionEvent.Type, EmitEvent With.Type) must not use the reserved IdLE. prefix; PreconditionEvent gains Level - EmitEvent: optional With.Type/With.Level, default IdLE.Step.EmitEvent.Emitted - PruneEntitlements emits IdLE.Step.PruneEntitlements.* instead of Information/Warning - docs/extend/events.md lists all event types (type, level, data) and the old -> new mapping; a test keeps it in sync with src Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Preconditions, steps, extensibility, DirectorySync provider reference and AGENTS.md 4.3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Verdict: PASS — Event renaming and the new Findings: no CRITICAL, MAJOR or MINOR findings. I reviewed the diff and grepped for stale event types. I did not run the Pester tests or the generated-reference check. |
Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #325
Summary
Event types now say what happened; the new
Levelfield says how severe it is.IdLE.<Area>.<Event>for first-party events,<Owner>.IdLE.<Area>.<Event>for extensions (convention). Workflow-defined types (PreconditionEvent.Type,EmitEventWith.Type) are free but must not start withIdLE.(ReservedNamespace).IdLE.Event.Level=Information|Warning|Error.Context.EventSink.WriteEvent(Type, Message, StepName, Data[, Level]): the fifth argument is optional (defaultInformation), so existing callers keep working.IdLE.Step.Failed/IdLE.OnFailure.StepFailed-> Error;IdLE.Step.Blocked/IdLE.Step.PreconditionFailed/IdLE.Step.Retrying-> Warning;IdLE.Run.Completed-> Error (Failed), Warning (Blocked);IdLE.OnFailure.Completed-> Warning (PartiallyFailed).Information,Warning,Error,Custom(InvalidEventType), listed inReservedNamespaces.psd1.PreconditionEvent: type validated at planning time; new optionalLevel.IdLE.Step.EmitEvent: optionalWith.TypeandWith.Level; default typeIdLE.Step.EmitEvent.Emitted. An invalidWith.Typefails the step at execution (no step-specific plan-time validation ofWithvalues exists).Old -> new
RunStarted,RunCompletedIdLE.Run.Started,IdLE.Run.CompletedStepStarted,StepCompleted,StepFailed,StepBlocked,StepNotApplicable,StepPreconditionFailed,StepRetryingIdLE.Step.Started,.Completed,.Failed,.Blocked,.NotApplicable,.PreconditionFailed,.RetryingOnFailureStarted,OnFailureCompletedIdLE.OnFailure.Started,IdLE.OnFailure.CompletedOnFailureStep{Started,Completed,Failed,NotApplicable}IdLE.OnFailure.Step{Started,Completed,Failed,NotApplicable}DirectorySync{Triggered,Waiting,Poll,Completed,Failed}IdLE.Step.DirectorySync.{Triggered,Waiting,Polled,Completed,Failed}Information/Warning(PruneEntitlements)IdLE.Step.PruneEntitlements.{Planned,EntitlementRevoked,EntitlementSkipped,KeepGranted,KeepGrantFailed}Custom(EmitEvent)IdLE.Step.EmitEvent.EmittedorWith.TypeProvider.AD.CreateIdentity.AttributesRequested,Provider.AD.EnsureAttribute.AttributeChangedIdLE.Provider.AD.AttributesRequested,IdLE.Provider.AD.AttributeChangedProvider.ExchangeOnline.Permissions.{Evaluated,Applying,Result}IdLE.Provider.ExchangeOnline.{PermissionsEvaluated,PermissionChanging,PermissionsEnsured}Breaking changes
Information,Warning,ErrororCustomas event type now throws.PreconditionEvent.Typevalues starting withIdLE.fail planning.Commits
docs/extend/events.mdinventoryTests
tests/Core/EventTypes.Tests.ps1(26 cases): Level defaults, rejected types,WriteEventwith 4 and 5 arguments, engine levels for success/failure/blocked,PreconditionEventType/Level validation, EmitEventWith.Type/With.Level, and a sync test that everyIdLE.*type emitted insrc/is documented indocs/extend/events.md.Results: Pester 958 passed / 0 failed; PSScriptAnalyzer no findings; step reference regenerated (only
EmitEventchanged).🤖 Generated with Claude Code