Skip to content

fix: resolve all 17 PSScriptAnalyzer code scanning findings #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blindzero merged 1 commit into from
Oct 31, 2026
Merged

fix: resolve all 17 PSScriptAnalyzer code scanning findings #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ....Provider.DirectorySync.EntraConnect/Public/New-IdleEntraConnectDirectorySyncProvider.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,12 @@ function New-IdleEntraConnectDirectorySyncProvider {
try {
$remoteSession = $this.NewRemoteSession($ComputerName, $AuthSession)

$this.InvokeRemoteCommand($remoteSession, {
$syncScript = {
param([string] $RemotePolicyType)
Import-Module -Name ADSync -ErrorAction Stop
Start-ADSyncSyncCycle -PolicyType $RemotePolicyType -ErrorAction Stop
}, @($PolicyType)) | Out-Null
}
$this.InvokeRemoteCommand($remoteSession, $syncScript, @($PolicyType)) | Out-Null

return [pscustomobject]@{
Started = $true
Expand Down Expand Up @@ -220,10 +221,11 @@ function New-IdleEntraConnectDirectorySyncProvider {
try {
$remoteSession = $this.NewRemoteSession($ComputerName, $AuthSession)

$scheduler = $this.InvokeRemoteCommand($remoteSession, {
$schedulerScript = {
Import-Module -Name ADSync -ErrorAction Stop
Get-ADSyncScheduler -ErrorAction Stop
}, @())
}
$scheduler = $this.InvokeRemoteCommand($remoteSession, $schedulerScript, @())

# Determine if sync is in progress
# Get-ADSyncScheduler returns an object with SyncCycleInProgress property
Expand Down
4 changes: 2 additions & 2 deletions src/IdLE.Provider.EntraID/Private/New-IdleEntraIDAdapter.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ function New-IdleEntraIDAdapter {
# HttpResponseHeaders (PowerShell 7 / HttpClient) does not support
# indexer-style access. Use GetValues() with a safety catch for the
# case where the header is absent (GetValues throws in that case).
try { $requestId = $_.Exception.Response.Headers.GetValues('request-id') | Select-Object -First 1 } catch { }
try { $retryAfter = $_.Exception.Response.Headers.GetValues('Retry-After') | Select-Object -First 1 } catch { }
try { $requestId = $_.Exception.Response.Headers.GetValues('request-id') | Select-Object -First 1 } catch { $requestId = $null }
try { $retryAfter = $_.Exception.Response.Headers.GetValues('Retry-After') | Select-Object -First 1 } catch { $retryAfter = $null }
}
}

Expand Down
15 changes: 7 additions & 8 deletions src/IdLE.Provider.EntraID/Public/New-IdleEntraIDIdentityProvider.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,10 +841,9 @@ function New-IdleEntraIDIdentityProvider {

# When Kind is supplied, only fetch the relevant directory objects.
# When Kind is null/empty, fetch both (backward-compatible, e.g. host-level reports).
$includeGroups = [string]::IsNullOrEmpty($Kind) -or
[string]::Equals($Kind, 'Group', [System.StringComparison]::OrdinalIgnoreCase)
$includeAUs = [string]::IsNullOrEmpty($Kind) -or
[string]::Equals($Kind, 'AdministrativeUnit', [System.StringComparison]::OrdinalIgnoreCase)
$kindIsEmpty = [string]::IsNullOrEmpty($Kind)
$includeGroups = $kindIsEmpty -or [string]::Equals($Kind, 'Group', [System.StringComparison]::OrdinalIgnoreCase)
$includeAUs = $kindIsEmpty -or [string]::Equals($Kind, 'AdministrativeUnit', [System.StringComparison]::OrdinalIgnoreCase)

$result = @()

Expand Down Expand Up @@ -1009,8 +1008,8 @@ function New-IdleEntraIDIdentityProvider {

# Split entitlements by kind: Groups use the Graph $batch path; AUs are processed per-item
# (no Graph batch API exists for Administrative Unit membership changes).
$groupOperations = @()
$administrativeUnitResults = @()
$groupOperations = @()
$administrativeUnitResults = @()

foreach ($ent in $Entitlements) {
$normalized = $this.ConvertToEntitlement($ent)
Expand Down Expand Up @@ -1107,8 +1106,8 @@ function New-IdleEntraIDIdentityProvider {

# Split entitlements by kind: Groups use the Graph $batch path; AUs are processed per-item
# (no Graph batch API exists for Administrative Unit membership changes).
$groupOperations = @()
$administrativeUnitResults = @()
$groupOperations = @()
$administrativeUnitResults = @()

foreach ($ent in $Entitlements) {
$normalized = $this.ConvertToEntitlement($ent)
Expand Down
Loading