build: use autoreconf to handle libtoolize selection - #39
Merged
Merged
Conversation
Collaborator
|
Excellent, thank you! |
Collaborator
|
If you'd like to contribute a nix test or package, I'd be open to it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
setup.pyusesglibtoolizeon MacOS andlibtoolizeon Linux. This is correct for Homebrew's MacOS toolchain but incorrect for Nix(pkgs) MacOS toolchain. In general, we don't want to hardcode the correctLIBTOOLIZEexecutable to use. Instead, the standard practice is to useautoreconfwhich handles thelibtoolizeselection for us. After this fix,libdash's Python module builds correctly as a Nix derivation on MacOS.Needed by atlas-brown/rt#5.