Repository navigation
[Refactor/#123] 카드 사이 간격 8px 통일 (행사 신청 폼·홈·열린피드백 작성내역) - #124
Open
sangrae2325 wants to merge 2 commits into
Open
sangrae2325 wants to merge 2 commits into
sangrae2325 wants to merge 2 commits into
Conversation
sangrae2325
added this pull request to stack #121
October 15, 2026 16:58
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sangrae2325
marked this pull request as ready for review
October 15, 2026 17:01
github-actions
Bot
requested review from
jjunh33,
leegain1,
tnals0924 and
xeoxxn
October 15, 2026 17:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
🎯 해결하려는 문제가 무엇인가요?
회색 배경 위 흰 카드 사이 간격이 화면마다 12px·8px로 섞여 있었다. 디자이너가 모두 8px로 정리했다(Figma
4174:101198간격통일).❓ 왜 해결해야 하나요?
같은 모양의 카드 목록인데 화면마다 간격이 달라서 앱 전체가 들쭉날쭉해 보인다.
실제뷰
⭐ 어떻게 해결했나요?
1. 카드 사이 12px → 8px (
7b260e5) —gap-3→gap-2EventsApplicationScreenHomeScreen3곳(배너↔섹션, 섹션끼리, 신청 카드끼리)FeedbacksMineList+ 스켈레톤학생회비 납부내역·사물함 배정 상태·행사 신청내역 상세는 #122에서 같이 바꿨다. 빌릴게·설정·탈퇴 확인은 원래 8px이다.
2. 규칙 문서화 (
95b7744) —component-convention.md크기·위치 절에 "회색 배경 위 흰 카드 사이는 8px(gap-2)" 추가🧩 이 PR의 한계 & 트레이드오프
flex-col gap-3이 더 남아 있지만 확인해 보니 흰 카드끼리 간격이 아니다 — 섹션 제목↔카드 묶음(빌릴게 반납), 질문·답변 블록 안쪽(열린피드백 상세), 구분선 목록(열린피드백 목록), 흰 배경 화면(아카이빙·행사 상세), 시트·모달 안쪽. 그대로 뒀다⛓️ 기존 기능에 미치는 영향
🔀 Edge Case & 실패 시나리오
📋 검토한 대안과 선택 이유
💬 리뷰 포인트
[a]남겨 둔gap-3들이 카드 간격이 아닌지