Repository navigation
[Feat/#110] 스플래시·로그인·온보딩 화면 구현 #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jjunh33
wants to merge
26
commits into
main
Choose a base branch
from
feat/#110-auth-onboarding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
7b9341d
docs: 인증·온보딩 용어 정리와 화면 WDS 매핑 추가
jjunh33 5380c50
feat: 목 로그인 API와 로그인 표시 저장소 추가
jjunh33 e32bcf3
feat: 스플래시·로그인 화면 추가
jjunh33 13bf2ba
feat: 온보딩 연락처·약관 동의·가입 완료 화면 추가
jjunh33 bb3659f
feat: 인증 라우트와 첫 진입 로그인 가드 연결
jjunh33 7c3d99c
chore: use-funnel 의존성 추가
jjunh33 724bdbd
feat: React Router 7 View Transition을 지원하는 useFunnel 어댑터 추가
jjunh33 0864cb9
refactor: 로그인·온보딩 화면을 useFunnel 퍼널 하나로 통합하고 스플래시 제거
jjunh33 d966087
docs: 인증 퍼널 구조와 View Transition 어댑터 설명 갱신
jjunh33 596b474
chore: oauth-kconnect 의존성과 GitHub Packages 설정 추가
jjunh33 a2dd124
feat: K-CONNECT OAuth 로그인 연동과 개발용 인증 우회 추가
jjunh33 452ddda
docs: K-CONNECT 로그인 연동과 목 테스트 방법 설명 추가
jjunh33 7e58fac
feat: 로그인 표시를 지우는 clearLoggedIn 추가
jjunh33 c9e411b
feat: 가입 연락처를 010으로 시작하는 11자리로 검증하는 함수 추가
jjunh33 a3e5cbb
refactor: 가입 퍼널의 단계 화면을 steps/로 분리하고 AuthSignupScreen으로 이름 변경
jjunh33 6283c5c
docs: 가입 퍼널 구조와 로그인 표시 지우기·연락처 기준 설명 추가
jjunh33 e3417a6
fix: main 리베이스 후 router.tsx의 알림·인증 라우트 정리
jjunh33 8663377
fix: 인증 목 코드를 authMock.ts로 분리하고 mockLogin 쿼리·응답 지연을 개발 서버에서만 쓰도록 수정
jjunh33 daf9e60
fix: 로그인 버튼이 bfcache 복원 후에도 눌린 상태로 남지 않도록 pageshow에서 해제
jjunh33 17e7fa2
refactor: 필수 약관 동의 여부를 TERMS의 isRequired 기준으로 판별
jjunh33 4f4aea6
fix: 온보딩 정보 저장에 실패하면 토스트로 안내
jjunh33 8f4e991
fix: 로그인 상태에서 가입 퍼널 진입 차단, 연락처 단계 뒤로가기, 실패 토스트 1회 노출, initial 메모이제이션
jjunh33 6e67adb
refactor: K-CONNECT 콜백에서 서버가 쓰는 값만 골라 전달
jjunh33 702864f
docs: 스플래시를 뺀 뒤 남은 로그인 가드 주석 수정
jjunh33 0cd5701
chore: 배포 빌드에 VITE_KCONNECT_CLIENT_ID 빌드 인자를 전달
jjunh33 22dbca8
chore: 로그인 일러스트를 PNG에서 WebP로 변환
jjunh33 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # K-CONNECT에 등록한 앱의 client_id (K-계정 관리 페이지의 OAuth2 애플리케이션) | ||
| # 복사해서 .env로 만들고 값을 채운다 — .env는 커밋하지 않는다. | ||
| # 허가된 Redirect URI에 http://localhost:5173/oauth/kconnect(개발)와 배포 주소의 /oauth/kconnect가 등록돼 있어야 한다. | ||
| VITE_KCONNECT_CLIENT_ID= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| @wanteddev:registry=https://npm.pkg.github.com/ | ||
| @wanteddev:registry=https://npm.pkg.github.com/ | ||
| @billilge:registry=https://npm.pkg.github.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # @billilge/oauth-kconnect는 Expo 앱용 의존성(expo-auth-session)을 optional peer로 선언하는데, pnpm의 | ||
| # autoInstallPeers가 그것까지 설치해서 웹에 필요 없는 Expo 의존성 수백 개가 딸려 온다. | ||
| # 이 앱은 웹용 진입점(@billilge/oauth-kconnect/react)만 쓰므로 설치에서 뺀다. | ||
| overrides: | ||
| expo-auth-session: "-" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[r]이대로 머지되면 dev 배포에서 홈에 들어갈 방법이 없어질 것 같아요.main에 push되면 dev가 자동 배포되는데, 지금 상태에서는 이렇게 돼요.
/에 들어가면AuthEntryGate가/auth로 보내요.VITE_KCONNECT_CLIENT_ID가 안 넘어가서K-CONNECT로 시작하기를 누르면 실패 토스트만 떠요.?mockKConnect=는import.meta.env.DEV에서만 동작해서 배포 빌드에서는 막혀 있어요.결국 홈을 보려면 콘솔에서 sessionStorage를 직접 넣는 방법밖에 없어요. 그리고
WDS_NPM_TOKEN에 billilge 패키지 읽기 권한이 없으면pnpm install단계에서 배포가 아예 실패하고요. 리뷰 포인트에 남겨 주신 CI 건은 후속으로 미루기보다 이 PR에서 같이 처리하거나, 처리 전까지는 가드를 잠시 꺼 두는 게 좋을 것 같은데 어떻게 생각하세요?