Skip to content

J5: test the Ansible scope history, and stop showing unrecorded values as null - #673

Merged
passcod merged 3 commits into
mainfrom
workhorse/j5
Oct 23, 2026
Merged

passcod merged 3 commits into
mainfrom
workhorse/j5

Conversation

@passcod

@passcod passcod commented Oct 23, 2026

Copy link
Copy Markdown
Member

🦸 Review Hero

  • Run Review Hero
  • Run Review Hero on Claude (before merge) Final review with Claude just before merging a substantive PR. Tick one or the other.

The scope history test aged its removal by updating the audit log, which the log's guard refuses. It now seeds an older removal into a week made for it, and covers a removal the recent list leaves out because the variable was set again. Adds Playwright coverage for opening a scope's history and putting back a removed variable from it.

Co-Authored-By: Claude <noreply@anthropic.com>
@passcod passcod changed the title J5: cover the Ansible scope history with tests J5: test the Ansible scope history, and stop showing unrecorded values as null Oct 23, 2026
passcod and others added 2 commits October 23, 2026 14:32
Removal and set entries recorded before the variable history began holding values have no value in their detail, and the history read that the same as a value of null, so it showed "Removed null". The history now says whether an entry recorded its value, and a change that recorded null is shown and put back as null.

Co-Authored-By: Claude <noreply@anthropic.com>
@passcod
passcod added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit c715cf1 Oct 23, 2026
13 checks passed
@passcod
passcod deleted the workhorse/j5 branch October 23, 2026 02:31
@passcod
passcod restored the workhorse/j5 branch October 23, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant