Repository navigation
fix: stop caching transient empty provider searches as permanent misses - #50
Merged
Merged
Conversation
|
🚅 Deployed to the api-pr-50 environment in better-lyrics
4 services not affected by this PR
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
QQ and Kugou searches sometimes come back empty for songs they have, and we cached that as a 7-day "no songs found". Before writing that miss, check whether the same provider already has lyrics for the song and artist under any album or duration. If it does, the miss only lives for 6 hours. The lookup uses a new partial index on qq/kugou
base_keys and gives up after 500ms, so a missing index just falls back to the old behaviour. The migration builds the index concurrently and skips it if it exists, so build it on prod by hand before deploying.