Ensure end-of-application object lifecycle is clean - #82
Open
freakboy3742 wants to merge 1 commit into
Open
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a Toga object is created, but not added to a layout, it creates a number of cyclic object references. When the application exits, these references are garbage collected. Rubicon deallocates those objects by marking them for autorelease, with a closure (through WrappedPyObject) to ensure that the Python object is also dropped.
When the autorelease pool exits, any object that is referenced by Python will be cleaned up via the closure - but the current code invokes Py_Finalize() inside the autorelease pool, so the Python interpreter has already shut down when the final ObjC objects are released. This causes a segfault because a non-existent Python interpreter is used in deallocation calls.
Refs beeware/briefcase-macOS-Xcode-template#134. It's much less of an issue on iOS because an app doesn't ever really "exit", but to ensure we're catching the edge case of a crash on actual app exit, it's worth maintaining parity.
PR Checklist:
Assisted-by: Claude Opus 5