Repository navigation
Compiler: a constant converts to its type even when that type was just rebuilt - #2588
Merged
bfiete merged 1 commit intoOct 27, 2026
Merged
Conversation
…t rebuilt Reifying a module rebuilds its types in place, back to undefined until they are populated again. A method declared in that window can resolve an attribute whose constructor has a default of such a type (an enum): GetTypedValueFromConstant asked the undefined enum whether it was a typed primitive, got no, failed the explicit cast silently, and the attribute was dropped from the method with no error. Seen in Sedulous's GUI: [GuiProperty]'s `GuiPropertyFlags flags = .None` default, and every Node property lost its attribute, depending on the order its types were first reached. GetTypedValueFromConstant now populates an incomplete type before converting to it. No test here: the window needs a type first made by comptime reflection before the compile's typedef loop reaches it, which hash order decides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reifying a module rebuilds its types in place, back to undefined until they are populated again. A method declared in that window can resolve an attribute whose constructor has a default of such a type (an enum): GetTypedValueFromConstant asked the undefined enum whether it was a typed primitive, got no, failed the explicit cast silently, and the attribute was dropped from the method with no error.
No test here: the window needs a type first made by comptime reflection before the compile's typedef loop reaches it, which hash order decides.