Repository navigation
Conversation
CeMachine::GetTypeInfo caches a type's method instances by its revision. A comptime call can reach a type through a cycle while that type is still declaring its methods (a generator on a derived type reading its base's methods, when declaring one of the base's methods populated the derived type), and the partial list was cached under the type's final revision, so every later GetMethods in the compile saw it. Which types came out short depended on compile order. Such a type is now answered with what it has but not cached, so a read after its methods are declared sees them all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CeMachine::GetTypeInfo caches a type's method instances by its revision. A comptime call can reach a type through a cycle while that type is still declaring its methods (a generator on a derived type reading its base's methods, when declaring one of the base's methods populated the derived type), and the partial list was cached under the type's final revision, so every later GetMethods in the compile saw it. Which types came out short depended on compile order.
Such a type is now answered with what it has but not cached, so a read after its methods are declared sees them all.