Repository navigation
Fix: Aws secondary key issue - #614
Open
ekrichbaum wants to merge 8 commits into
Open
ekrichbaum wants to merge 8 commits into
ekrichbaum wants to merge 8 commits into
Conversation
Added note about S3 bucket tagging permissions and implications for discovery.
Refactor custom field handling and remove unused code.
Add test for unscoped cluster warning in logging.
Previous adoption of original code dropped the required custom fields to match. This patch adds a guide for empty/missing and still allowing for true name collision.
Updated assertions for name collision and bucket checks in AWS service tests. Added new tests for EKS cluster handling with missing identity fields and conflicting identity fields.
Added a test to ensure VM lookup does not serialize cluster metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes secondary key with adjustments to object_classes.
Updates docs accordingly.
Fixes test accordingly.